ci: let green PRs merge and deploy themselves - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
s-ink has
ci.ymlanddeploy.ymlbut no auto-merge, so every green PR waits on a human. #6 has been sitting green andCLEANfor exactly that reason. This is the same policy the rest of the fleet runs.Two things adapted for this repo
1.
checks: read+statuses: read— required because s-ink is private. The sweep readsstatusCheckRollupto decide whether a PR is green; a public repo answers that with no explicit scope, which is why the copy circulating the fleet omits them and still works in ~20 public repos. On a private repo it fails withResource not accessible by integrationand merges nothing, ever — see bitbaum/ivy-portal#4, where that went unnoticed for days. Fixed at source in bitbaum/dotfiles#6.2.
REARM_WORKFLOWS: ci.yml deploy.yml— not justci.yml. Deploy here triggers onpush: [main], and a merge made with the defaultGITHUB_TOKENdoes not cascade into other workflows. Without re-arming Deploy explicitly, this repo would merge PRs correctly and then silently never ship them. FleetCrown hit exactly that and needed a reconciler to dig out.Effect
A green, non-draft PR merges itself and reaches the box. Hold work back with a draft PR or a
hold/no-automerge/do-not-merge/wiplabel.🤖 Generated with Claude Code