fix(ci): stop skipping conflicts, and keep branches current - #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from bitbaum/orangecat#645, where these two gaps stranded a PR for
hours and a third was found while auditing the fleet.
The merge train optimised for merging and had nothing to say about not
merging. Three different stuck states all rendered as a polite skip:
in silence, every sweep, forever. Nothing else will unstick it, so silence is
the wrong answer. Now it is logged to stderr and written to the job summary.
not have been proven against, and conflicts surfaced hours after the merge
that caused them. Now a
BEHINDbranch is updated first — one per sweep, forthe same reason only one PR is merged per sweep — which also makes conflicts
appear minutes after the merge that caused them.
PERMANENT for an old one: GitHub does not retroactively run workflows on a PR
nobody has pushed to. Over-2h-old checkless PRs are now surfaced in the job
summary instead of waiting patiently forever.
Behaviour verified against the real script with a fake
ghon PATH — conflictreported and not merged; behind-updated and not merged; clean still merges
(no regression); old checkless PR surfaced; brand-new one stays silent.
🤖 Generated with Claude Code