fix(auth): sign-in control visible on first paint - #74
Merged
Conversation
The loading branch rendered an empty placeholder, and SSR is always in the loading state — so the nav's sign-in control was invisible until the client-side session fetch finished. Default to the signed-out button instead: most visitors are signed out, and a signed-in user just sees it swap to their name. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73. The auth control's loading branch rendered an empty placeholder, and SSR is always in the loading state — so "Sign in with OrangeCat" was invisible until the client-side session fetch finished (and invisible to anything without JS). Default to the signed-out button: most visitors are signed out; a signed-in user sees it swap to their name once the session arrives.
Verified:
npm run verifygreen (33 tests).🤖 Generated with Claude Code