fix(health): stop gating HTTP status on AI vendor health - #38
Merged
Conversation
The `?strict=1` mode 503'd when the LLM chain was down, even though a dead vendor key can't be fixed by restarting the process. A monitoring system that restarts on a failing health check would loop pointlessly on a problem restarting can't solve. Health status is now always 200 once the process is up; `llm` stays in the response body as an informational field. `strict` had no other purpose, so its handling is removed entirely rather than left as dead branching. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HVwg8DKHQktxJuHeLM3xpG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/health?strict=1returned 503 when the LLM health tracker reported "down" — but a dead vendor key or exhausted budget can't be fixed by restarting the process, so a monitoring system that restarts on a failing health check would loop pointlessly.llmhealth stays in the response body as an informational field only.stricthad no other legitimate purpose in this route, so its query-param handling is removed entirely rather than left as dead branching.Test plan
npm run verify(format, lint, typecheck, test) — all greensrc/lib/health.test.tsexists, covering the tracker state machine, unaffected)🤖 Generated with Claude Code