Skip to content

fix(nav): the admin overflow sheet was the one surface that stayed silent #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Aug 31, 2026
Merged

fix(nav): the admin overflow sheet was the one surface that stayed silent #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions app/(admin)/admin.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2181,17 +2181,30 @@
display: flex;
align-items: center;
gap: 0.65rem;
/* 0.65rem of padding around 0.85rem text lands near 41px at this root
size — just under the floor .bottomNavItem already states explicitly.
The overflow sheet is a touch surface like any other; say the minimum
rather than arriving near it by arithmetic. */
min-height: 44px;
padding: 0.65rem 0.85rem;
border-radius: var(--radius-lg);
color: var(--white-90);
text-decoration: none;
font-size: 0.85rem;
}

.moreSheetItem:hover,
.moreSheetItem:hover {
background: var(--white-7);
}

/* Hover and focus were one rule, so keyboard focus was indicated by a 7%
white wash and nothing else — the weakest possible signal, on the surface
where a keyboard user most needs to know where they are. Focus gets a real
ring; hover keeps the wash. */
.moreSheetItem:focus-visible {
background: var(--white-7);
outline: none;
outline: 2px solid var(--white-90);
outline-offset: -2px;
}

/* Tighter header padding */
Expand Down
6 changes: 6 additions & 0 deletions components/admin/AdminNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,11 +353,17 @@ export function AdminBottomNav(props: AdminBadgeProps) {
const Icon = ROUTE_ICONS[href];
const count = badgeCount(href, badges);
const urgent = ROUTE_BADGE_KEYS[href] === "patients";
// The sidebar and the bottom bar both announce the current page.
// The overflow sheet did not — so the destinations that happened
// to land behind "More" were the ones a screen-reader user could
// not locate themselves in.
const active = isActive(pathname, href);
return (
<Link
key={href}
href={href}
className={styles.moreSheetItem}
aria-current={active ? "page" : undefined}
onClick={() => setMoreOpen(false)}
>
<span className={styles.navIcon}>
Expand Down
Loading