feat: Added websocket ping functionality - #36
Merged
d0sboots merged 1 commit intoAug 28, 2025
Conversation
This was referenced Aug 28, 2025
Closed
d0sboots
reviewed
Aug 28, 2025
| signaller.trigger(EventType.ConnectionMade); | ||
| }); | ||
|
|
||
| const interval = setInterval(function ping() { |
Collaborator
There was a problem hiding this comment.
I think these should be inside the .on("connection", it's probably not valid to ping on an unopened connection.
Author
There was a problem hiding this comment.
I put it in the place that the library documentation shows it. https://github.com/websockets/ws?tab=readme-ov-file#how-to-detect-and-close-broken-connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature has been tested, linted, and formatted. Sends a websocket ping every 10 seconds to keep it alive.