Support specifying host to bind to in config - #37
Open
DarkOtter wants to merge 1 commit into
Open
Conversation
This should allow running listening only on localhost for better security when bitburner and the sync are both run on the same host, which I imagine is common. Ran tests for commit: npm run format npm run lint npm run test (all tests passed) Ran the program with unchanged config (no host specified), observed still listening on [::], observed able to connect and sync from bitburner on another host. Added the host option set to localhost, ran again and observed I was unable to connect from the other host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow running listening only on localhost for better security when bitburner and the sync are both run on the same host, which I imagine is common.
Ran tests for commit:
npm run format
npm run lint
npm run test
(all tests passed)
Ran the program with unchanged config (no host specified), observed still listening on [::], observed able to connect and sync from bitburner on another host.
Added the host option set to localhost, ran again and observed I was unable to connect from the other host.
AI use: I asked AI for advice to save figuring out some project details myself, but all of the code changes were written myself.