Conversation
The v2 prefix is the only one in use; the v1 restore key was a one-run transitional fallback and is not needed.
Three test spots reversed digests or sliced header bytes by hand where b2lx, lx and CBlockHeader.deserialize already do the job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workflow's cache restore listed
prevouts-v1-as a fallback behind the currentprevouts-v2-prefix (sanitycheck.yml). That only ever served the first run after the prefix changed, so it is removed along with the schema sentence that described it. A survey of the three CI modules against python-bitcoinlib 0.12.2 found the evidence code already using the library for parsing, merkle roots, script classification and byte order, and found the two deliberately custom pieces still necessary: the mainnet proof-of-work limit, because the library'sPROOF_OF_WORK_LIMITis far looser than the real genesis target, and the compact-target sign-bit check, becauseuint256_from_compactdoes not reject it. Three test spots reversed digests or sliced header bytes by hand; they now callb2lx,lxandCBlockHeader.deserialize.Testing
All 36 tests pass on the branch and the offline
python ci/sanity-check.pyis unaffected. The workflow change is exercised by this PR's own run.