feat(dataset): record the Chaincode node behind 389043's full block - #27
Merged
Merged
Conversation
PR #26 replaced the coinbase proof for 389043 with the complete block, found on the long-running Chaincode Labs nodes whose stale blocks entered stale-blocks in bitcoin-data/stale-blocks#156. Add the p2p observation naming that source, count the 37 remaining Namecoin AuxPoW coinbase proofs in the notes, and say there where the body came from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#26 replaced 389043's coinbase proof with its complete block, found on the long-running Chaincode Labs nodes described in bitcoin-data/stale-blocks#156. This adds a
p2pobservation withchaincodeas the source and #26 as the provenance, and corrects the notes: 37 Namecoin AuxPoW coinbase proofs remain, and a sentence says where the body came from. The record is otherwise unchanged.Testing
python ci/sanity-check.py: 143 blocks, 378 observations, 17 block files, 123 proof files; 49 tests pass. The site renders the observation on the block page and the corrected count on the notes page.