Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four AntPool blocks from 2018, at heights 507514, 509557, 515319 and 534339, include non-coinbase transactions that their canonical parent had already confirmed, so
ConnectBlockfails atCheckTxInputswithbad-txns-inputs-missingorspent. 515319 is a complete copy of its parent's 79 non-coinbase transactions; the other three carry a subset or a mix of parent transactions and new ones. The same AntPool worker mined parent and child each time, which reads as a template that updatedhashPrevBlockwithout rebuilding the transaction list: the sibling of 584802, where the transactions were dropped and their fees kept.No existing rule looks at the parent's transaction list, so these passed every context-free body check. The new rule
already_confirmed_in_parentkeeps the same reject string and requires a complete body plus aparent_txidthat is a non-coinbase transaction in both the body and the canonical parent.ci/prevouts.pyfetches the parent header, which must hash toprev_hash, and the parent's ordered txid list, which must reproduce that header's merkle root, then checks membership with the parent's coinbase excluded. The canonical hash at height minus one must equalprev_hash. The evidence is cached as{prev_hash}.header,{prev_hash}.txids.jsonandheight-{n}.hash, and the workflow cache prefix moves toprevouts-v2-withv1kept as a fallback. Only the immediate parent is considered.Each record carries
pool: AntPoolwithpool_basis: tagand onescrapeobservation citing the pinned chainquery snapshot in the mergedmonitor archive, which labels the four asinvalidtips; that label started the search and is not the evidence. On 17 September 2026 a Bitcoin Core v31.1.0 node rewound to each parent returnedbad-txns-inputs-missingorspentfromsubmitblockfor all four. Schema, notes and README are updated. The four rows and bodies come out of bitcoin-data/stale-blocks in a separate PR there once this is published.Testing
All 36 tests pass, including the new cases for a
parent_txidabsent from the body or from the parent list, the coinbase named asparent_txid, a list that does not match the merkle root, a non-canonicalprev_hash, and a missing cached list. Offlinepython ci/sanity-check.pyreports 52 blocks, 52 contexts, 195 observations and 10 block files; with--fetch-prevoutsit downloads nothing and passes. The four bodies are byte-identical to the stale-blocks copies, and the existing admissions are unchanged.