BIP3: drop optional License Code header#1904
Merged
murchandamus merged 2 commits intoJul 29, 2025
Merged
Conversation
jonatack
added
Proposed BIP modification
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Thanks, looks good. Could you please also mention in the Backwards Compatibility section under Preamble that the License-Code has been sunset?
Contributor
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
Sorry for being slow. This was on my list, thanks for taking care of it!
jonatack
force-pushed
the
2025-07-remove-License-Code-from-BIP3
branch
2 times, most recently
from
45af64c to
fd16929
Compare
Member
Author
|
Updated to take all the review feedback (thanks!). |
Member
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
Thanks, good improvements.
| - The "Post-History" header is replaced with the "Discussion" header. | ||
| - The optional "Version" header is introduced. | ||
| - The "Discussions-To" header is dropped as it has never been used in any BIP. | ||
| - The "License-Code" header has been sunset, as it was used by only five BIPs (98, 116, 117, 330, 340) and created more ambiguity than clarity. |
Member
There was a problem hiding this comment.
Just noticed that this says License-Code was used by five BIPs, but below line 734, it says that License-Code was used four times. I must have overlooked BIP 340. But since line 546 is just being introduced here, perhaps it could be made consistent.
Co-authored-by: Tim Ruffing <crypto@timruffing.de> Co-authored-by: Murch <murch@murch.one>
per https://creativecommons.org/publicdomain/zero/1.0/legalcode.en and add a missing word Co-authored-by: Tim Ruffing <crypto@timruffing.de>
jonatack
force-pushed
the
2025-07-remove-License-Code-from-BIP3
branch
from
fd16929 to
6f2f4aa
Compare
jonatack
removed
the
Pending acceptance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on @real-or-random's #1892 (comment).
Also a couple of minor BIP3 touch-ups.