Skip to content

feat(wallet): add Wallet::sign_with_signers#490

Open
noahjoeris wants to merge 2 commits into
bitcoindevkit:masterfrom
noahjoeris:feat/sign-with-signers
Open

feat(wallet): add Wallet::sign_with_signers#490
noahjoeris wants to merge 2 commits into
bitcoindevkit:masterfrom
noahjoeris:feat/sign-with-signers

Conversation

@noahjoeris
Copy link
Copy Markdown

@noahjoeris noahjoeris commented May 26, 2026

Description

Adds Wallet::sign_with_signers, allowing callers to pass signer containers. Wallet::sign now delegates to this new method, so the existing API remains unchanged.

This is a small step toward removing signer ownership from Wallet and improving separation of concerns. In the future we can deprecate Wallet::sign and remove the wallet signer fields.

Changelog notice

- Added `Wallet::sign_with_signers`.

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.58%. Comparing base (6dca318) to head (24564ed).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   80.55%   80.58%   +0.02%     
==========================================
  Files          24       24              
  Lines        5472     5479       +7     
  Branches      243      243              
==========================================
+ Hits         4408     4415       +7     
  Misses        987      987              
  Partials       77       77              
Flag Coverage Δ
rust 80.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet May 26, 2026
@ValuedMammal ValuedMammal added this to the Wallet 3.1.0 milestone May 26, 2026
@ValuedMammal ValuedMammal added the new feature New feature or request label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

2 participants