Repository navigation
qt: Stage 2/2 — add safe Ord wallet and inscription UI - #14
Open
StanCan321 wants to merge 5 commits into
Open
StanCan321 wants to merge 5 commits into
StanCan321 wants to merge 5 commits into
Conversation
Author
|
Security-hardening pass pushed in |
Move recovery acknowledgment to an application-owned non-copyable dialog and persist the backup gate before wallet creation. Isolate Ord settings and pin index and RPC paths. Freeze inscription funding inputs and reject unauthorized broadcasts through a wallet-scoped authenticated RPC gate. Bind cancellation to its invocation and check image preview handles. Add Qt and real Ord regtest regressions.
StanCan321
marked this pull request as ready for review
October 9, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 2 of the Ord integration
Dependency and scope
This PR intentionally builds on #12 rather than duplicating or replacing its installer design. It remains in draft while CI and maintainer review validate the safety model.
Summary
ordord/data-runes-sats-v1index, preserving incompatible legacyord/dataindexes127.0.0.1, parse the kernel-selected port from the child, and require a valid/blockcountresponse before wallet useSafety properties
--name ord127.0.0.1on a kernel-assigned ephemeral port--no-limit, reinscription, parent, delegate, metadata, and rare-sat selection remain unavailableIndex migration
Ord 0.29.0 does not retrofit sat tracking into an index originally created without
--index-sats, even if a laterindex updateincludes the flag. This PR therefore does not silently reuse or delete the Stage 1 index. It builds the required asset-aware index inord/data-runes-sats-v1and leavesord/datauntouched.Upgrades require a fresh synchronization and temporarily need space for both indexes. The legacy directory can be removed manually only after the new index is synchronized and the dedicated Ord wallet has been verified.
Test plan
bitcoin-qtbuildReview notes
The first commit introduces the experimental inscription page. The second adds wallet onboarding and the end-to-end flow. The third is an adversarial security-hardening pass covering preview authorization, file TOCTOU, mnemonic handling, address/amount validation, asset-aware coin safety, loopback lifecycle, proxy behavior, cancellation, hostile image/file inputs, migration behavior, and expanded tests.
Image resizing or lossy recompression remains deliberately out of scope. The UI exposes only Ord's lossless Brotli option so the snapshotted bytes remain auditable.