Repository navigation
policy: Allow negative modified fees for ephemeral dust - #438
Open
connorslab wants to merge 1 commit into
Open
connorslab wants to merge 1 commit into
connorslab wants to merge 1 commit into
Conversation
connorslab
marked this pull request as ready for review
October 4, 2026 01:00
Collaborator
Disabling it seems like the wrong solution. Why not just allow ephemeral anchors to have negative feerates? |
luke-jr
reviewed
Oct 4, 2026
luke-jr
left a comment
Collaborator
There was a problem hiding this comment.
Might make sense to drop the corepolicy overrides?
kwsantiago
approved these changes
Oct 4, 2026
kwsantiago
left a comment
There was a problem hiding this comment.
tACK e77fe14. Please squash out the defaults change and its revert, and note that -mempooltruc=enforce is required.
connorslab
force-pushed
the
policy-monetary-defaults
branch
from
October 4, 2026 22:51
e77fe14 to
e5235ec
Compare
connorslab
force-pushed
the
policy-monetary-defaults
branch
from
October 5, 2026 18:11
e5235ec to
e155555
Compare
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the automatic sub-dust fee penalty on otherwise eligible ephemeral-dust transactions without permitting manual fee deltas.
Move the existing ephemeral fee precheck before the automatic dust-penalty deduction. At this point
StageAdditionhas already applied the fee adjustments frommempool.mapDeltas, so the existing zero-base-fee and zero-modified-fee checks reject any nonzero net manual fee delta. The original precheck itself is unchanged; no duplicate penalty calculation or direct map access is needed.Knots then applies its existing calculated dust penalty. A zero-value P2A output produces a -240-sat modified fee at 3 sat/vB dust relay, or -480 sats at 6 sat/vB. With the penalty disabled, it remains zero. The child must still cover the penalty and required package fees. Existing RPC policy continues to prohibit fee adjustments after a dust transaction enters the mempool.
No defaults,
corepolicyoverrides, TRUC rules, or dust-spending restrictions change. The intended version-3 parent/child anchor packages require-mempooltruc=enforce. The separate default-policy proposal is in #439.Regression coverage tests two dust relay rates and disabled penalties, positive and negative pre-admission manual fee deltas, post-admission RPC rejection, the package fee boundary, child replacement, block-template inclusion and confirmation.
Validation of
e155555218104959bb4172707b02ce2fd2413489: Linux build and targeted policy tests passed: the release build, 18 targeted unit tests, and five functional suites. The legacy-wallet variant was skipped because Berkeley DB was disabled; the GUI was not built. Python syntax andgit diff --checkpassed. The validation workflow is on a separate branch and is not part of this PR.