Repository navigation
Cover the historical coinbase maturity window on regtest - #482
Open
kwsantiago wants to merge 3 commits into
Open
kwsantiago wants to merge 3 commits into
kwsantiago wants to merge 3 commits into
Conversation
5 of 24 tasks
kwsantiago
force-pushed
the
cbm-historical-regtest
branch
from
October 30, 2026 19:28
4fcc7ee to
182af72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainnet enforces two coinbase maturity schedules at once: the 6480-block window for rewards from 973440 (consensus until 979920; relay keeps holding them after that) and the rolling rule from 979919. Regtest could only configure the rolling rule, so no functional test covered the window or where the two overlap.
This adds
-testcoinbasematurityhistorical=<start_height>:<release_height>(regtest only). It requires-testcoinbasematuritylongwith-testcoinbasematuritylongexpiry, and a release height at most one above the rolling start, which is mainnet's layout. It sets the window through the same helper mainnet now uses, so the parameters and revalidation markers match mainnet's.feature_historical_coinbase_maturity.pycovers, at a mainnet-shaped scale:getdeploymentinfobefore and after the switchNo mainnet, testnet or signet parameters change.