Repository navigation
Promote: fix: repair Mining pool ranking (explorer.pool-ranking) - #165
Merged
Merged
Conversation
Fixed a backend stall that can keep the pool ranking chart from drawing, but nothing was verified: I could not probe the live site or run any check in this sandbox. What I could not confirm: curl to explorer.bitcoinuniverse.io was blocked, so I never saw the failing response. The cause below is traced from source only. Likely cause: the page (PoolRankingComponent) draws its pie from GET /api/v1/mining/pools/:interval and gives up after 20 seconds. That route (Mining.$getPoolsStats in backend/s Prepared by Universe X run run_IzL6X5SYEhoc. Not released.
Fix made but NOT verified: no test, lint or build could run (no node_modules in this worktree), and the live failure reason was not confirmed (requests to the live site were denied, no server access). Defect fixed: the home dashboard printed a backend failure to visitors. Whenever the mempool backend marks its replacement (RBF) history unavailable, or no summary arrives within 35 seconds, the "Recent replacements" panel rendered the alert "Replacement history is unavailable." plus a Retry butto Prepared by Universe X run run_CCC_6nk3-0Kr. Not released.
…-ranking-SYEhoc fix: repair Mining pool ranking (explorer.pool-ranking)
…board-k3x0Kr fix: repair Live Bitcoin dashboard (explorer.dashboard)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a backend stall that can keep the pool ranking chart from drawing, but nothing was verified: I could not probe the live site or run any check in this sandbox.
What I could not confirm: curl to explorer.bitcoinuniverse.io was blocked, so I never saw the failing response. The cause below is traced from source only.
Likely cause: the page (PoolRankingComponent) draws its pie from GET /api/v1/mining/pools/:interval and gives up after 20 seconds. That route (Mining.$getPoolsStats in backend/src/api/mining/mining.ts) reads the ranking from the database, then makes three sequential getnetworkhashps calls to Bitcoin Core on the shared bulk RPC pool. Each call may wait up to CORE_RPC.TIMEOUT (60 s in the sample config). A node busy with indexing can therefore hold the response for up to about 180 s, although the ranking is already complete from the database. The browser times out, shows the error panel, and no chart is drawn.
Fix: the three hashrate estimates now share one 5 second budget. If the node does not answer in time, the route returns the indexed ranking with the existing zero hashrate fallback, and no further RPC calls are issued after the budget expires. Route shape and frontend are unchanged. I added a jest test for the busy-node and healthy-node cases.
Not run: the worktree has no node_modules and npm ci was blocked, so the new test, tsc and lint have not been executed. Run in backend: npx jest src/tests/mining-pools-stats-deadline.test.ts, plus npm run lint
Found by a live Universe X journey (run run_IzL6X5SYEhoc) and repaired automatically. Checks reported by the fixer: Live probe of https://explorer.bitcoinuniverse.io/api/v1/mining/pools/* with curl: blocked by sandbox permissions, not run, npm ci in backend to run jest: blocked by sandbox permissions, not run, jest backend/src/tests/mining-pools-stats-deadline.test.ts: not run (no node_modules in worktree), g.
🤖 Generated with Claude Code