Add callback interface to put_* functions#27
Conversation
This adds a callback function interface to all put_* functions in the Generation. Often we need to get something from the pipeline and pass other values in again. Like this we can implement this without breaking the pipeline.
|
Actually, looking at the other PR in here I am not sure anymore if we should not duplicate the types and create types for all putable things instead. |
|
I think API-wise, I would prefer to leave the Instead we could have more semantic functions take the callback, what should already be in place for most parts of the pipeline. For instance What's missing are those for context, context_sources, prompt and evaluation. Something along In my mind that would leave put_* functions as escape hatches when you need control (and break the pipeline). What do you think? |
Yes, it would be better to define those types but I think it's not needed for now. |
|
closing in favor of #30 |
This adds a callback function interface to all
put_* functions in the Generation.
Often we need to get something from the pipeline and pass other values in again. Like this we can implement this without breaking the pipeline.