Webserver fixes - #15
Open
stargo wants to merge 3 commits into
Open
Conversation
This allows the webserver to be immediately restarted when it was stopped and not having to wait for the local port to be available again while it is in TIME_WAIT state.
This fixes the crash when generating the screenshot on the server side and no character rom was specified on the command line by reading the character rom from the configuration instead.
This sends back the last known good vram image on read error to avoid flickering. Also declare any read-error as failure even though a retry is successfull, as it seems there is a problem with the retry- implementation somewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SO_REUSEADDR to be able to restart the webserver immediately
after terminating and fix png generation when no character rom
was specified on the command line. Also send the last know good
vram image back to the browser on read-errors to avoid flickering.