Added option to leave group#135
Open
KamalGalrani wants to merge 6 commits into
Open
Conversation
Contributor
Author
UPDATE:To leave group chats using channel name |
dequis
reviewed
Feb 25, 2017
| static void fb_cmd_fbchats(irc_t *irc, char **args); | ||
| static void fb_cmd_fbcreate(irc_t *irc, char **args); | ||
| static void fb_cmd_fbjoin(irc_t *irc, char **args); | ||
| static void fb_cmd_fbleave(irc_t *irc, char **args); |
Member
There was a problem hiding this comment.
What is this whole block? Please don't include unrelated changes
Member
|
Thanks but I'm not sure I like this approach. I'd prefer to reduce the amount of root commands added by this plugin - I was already working on removing fbjoin and fbchats. Bitlbee specific code must not be used outside of facebook.c, since all the other files are shared with purple-facebook |
Contributor
Author
|
The block is simply declaration of all the functions defined in facebook.c.
I was using fb_cmd_fbchats in fb_login when I realized that the function is
defined after fb_login. So I just put declaration of all the functions in
the beginning of file for convenience. All but 2 declarations can be
removed.
How are you planning to do away with fbjoin and fbchats?
I don't think there is any bitlbee specific code outside facebook.c in the
pull request.
|
|
I would like to see this feature. Can it be accepted or has something similar been implemented? Leaving facebook group chats. |
Contributor
|
Could you bridge it with /PART? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fetches group chats automatically on login and adds an option to leave a group chat. You can only leave group chats that appear in
fbchats. To leave other groups first add them tofbchatsusingchat add facebook <thread_id> #<channel>Usage
To leave group chats using
fbchatsindexTo leave group chats using thread id