Repository navigation
fix(person): bind admitted memory rows and clarify publication outcomes (A4/A3) - #214
Merged
bitmaster162 merged 3 commits intoOct 20, 2026
Merged
Conversation
This was referenced Oct 14, 2026
bitmaster162
changed the base branch from
agent/person-export-actor-deny-local-r1
to
master
October 20, 2026 19:38
bitmaster162
marked this pull request as ready for review
October 20, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current target and exact revision — reviewed integration scope
A4 → A3, targeting protected
masterafter #213 merged. The owner has explicitly approvedAPPROVE_CONTINUITYOS_PR214_REVIEW_NOTE_READY_AND_NORMAL_MERGE_ONLYfor the pinned revision below: update this description, change Draft to Ready, then perform one ordinary merge commit only after a fresh successful base/head/tree/scope/CI/protection preflight. This authorization is not itself a claim that those operations have completed; the live PR state and post-operation readback determine completion. Deployment, release, runtime activation and production admission remain unauthorized.master.79d5fc783cf6c735067f26bdfad3ea0e396dd3e8.12f878b06bef3435226ce51436a37d8a876f2dda.agent/person-a3-publication-result-local-r1.c7d1d8ec2183b082e17c47f99e42360a600d1aad.de6a73eceea53ec2e864bf1254a7de0ef7d129b6.de6a73eceea53ec2e864bf1254a7de0ef7d129b6.79d5fc783cf6c735067f26bdfad3ea0e396dd3e8, then HEADc7d1d8ec2183b082e17c47f99e42360a600d1aad.34d02e44104146beba7b174a88d58270606891fd, then pinned master79d5fc783cf6c735067f26bdfad3ea0e396dd3e8.The two original corrective commits remain unchanged: A4
fe04df409f86bc773d7210dbfaefa620afc3a231(tree8b52fb2e3986e2c159cbcf38e0e56497e0369b4a) → A334d02e44104146beba7b174a88d58270606891fd(tree41f31d9ce16693b47c392c31d1f4b845cc6b0f2e). Their original prerequisite was #213 HEADb11af1a69957e77accc0a6d74dedb7c4dab8ee28, and the old base branch wasagent/person-export-actor-deny-local-r1. Those identifiers describe historical publication, not the current PR target.The extra commit is the ordinary, history-preserving branch update, not a new code fix. Its delta against the original A3 HEAD is only the four already-integrated Company Twin demo files (+763/-0). No additional source edits, rebase, force-push, workflow changes or new corrective commits were made. Only this feature branch was pushed during that update; protected master and other branch heads were preserved.
A4 — enforce the saved admission-to-memory-row binding
Reproduced predecessor behavior
A synthetic admission was persisted for
mem:3. A distinct CURRENT rowmem:4with identical text, namespace and acceptable metadata could be selected by the intent. The real R21H path then produced ALLOW and sentmem:4to a recording model client. Different text, different namespace, superseded metadata and missing-row controls were already denied.This was a source-identity guarantee violation, not proof of cross-tenant disclosure or a live-model exploit.
Correction
PersonTwinAdmissionStore.read_current_memory_binding_bytes()reads one verified persisted CURRENT snapshot. It receives no request/intent row id and does not manufacture admission from caller pins._readpath is used for preparation and final prompt revalidation.A3 — distinguish an attempted publication from an acknowledged COMMIT
Reproduced predecessor behavior
An injected denial immediately before promotion COMMIT returned HOLD with an allocated
publication_id, although no publication row existed. Candidate staging could already be committed. A failed post-COMMIT readback, conversely, could legitimately leave a persisted publication while returning HOLD.Correction
Only
_resultchanges in the A3 runtime delta (one line replaced by two):attempt_publication_idretains the allocated attempt id, including uncertain outcomes, for later reconciliation.publication_idis emitted only when promotion COMMIT was acknowledged as CONFIRMED; otherwise it is null.Consumer-contract change: strict consumers of the outer
admit()result must account for the additional field. A non-nullpublication_idis not fresh CURRENT, consent, READ authority, or production signoff. Consumers must inspectstatus,commit_state, the receipt and applicable fresh authorization rather than infer permission from a non-null ID.Exact file scope against pinned master
continuityos/person_twin_admission_store.py: modified, +22/-2; saved-binding read port and publication-result clarification.continuityos/person_twin_r21h_evidence.py: modified, +37/-0; mandatory binding verification in the existing adapter.docs/PERSON_ADMISSION_PUBLICATION_RESULT_A3_R1.md: added, +94/-0; attempted/confirmed publication contract and outcome matrix.docs/PERSON_R21H_MEMORY_BINDING_A4_R1.md: added, +82/-0; A4 contract, checks and limitations.tests/test_person_twin_admission_store.py: modified, +401/-0; A4 and A3 regressions; old test bodies retained.tests/test_person_twin_r21h_evidence.py: modified, +16/-1; seeded binding support in the existing synthetic fixture; prior test bodies retained.Historical local evidence — original corrective revision, not a new local run
The following results belong to the original A4/A3 revision and are not relabelled as local tests of the new merge HEAD. Windows / Python 3.11.9, synthetic temporary SQLite databases and recording model clients only:
cos demo person-continuity --jsonCOS_DEMO_PERSON_CONTINUITY_PASSThe two skips concern real filesystem symlink creation unavailable to that Windows process. They are not PASS. Backup → revoke → restore still denies READ before model generation with a current external revocation ledger; a deliberately stale ledger remains a trusted-input limitation, not a newly solved native witness problem. No cross-machine or authenticated-principal qualification is claimed.
Historical failed attempts are preserved: the first A4 candidate unnecessarily added a receipt field incompatible with the exact demo validator; the field was removed rather than relaxing validation. A separate A3 audit runner initially omitted
SCHEMA; the runner was corrected outside product source and passed on the same runtime bytes. Original red reproductions remain separate from later green runs.Original publication preflight rechecked the clean branch, exact two-commit chain/scope, 728/728 tracked files against
git archive, all 19 members of the sealed A3 manifest, and the bundle. Original A3 manifest SHA-256:a9260da827138bd08f467d7fed7b1b8d657d5344fbf4ff3137be6fd3f073e2fa. Original two-commit bundle SHA-256:00307649e2e255394a7957c5b72e6601243871000f436fa00a054bdb1bdd0b0d; its prerequisite is the original #213 HEAD. These original artifacts were not rewritten by this update. Unsigned commit hashes are not owner-identity attestations.Current exact-HEAD CI — 5/5 SUCCESS
All five registered checks on exact HEAD
c7d1d8ec2183b082e17c47f99e42360a600d1aadcompleted successfully. Times below are UTC on 2026-10-20:Automatically triggered workflows, all completed with SUCCESS on attempt 1:
Both review-job logs record checkout of
refs/pull/214/mergeat synthetic commit9f770fb1b5d7b92518d71c35f6430d80cc69fb3f. Its parents are pinned master79d5fc783cf6c735067f26bdfad3ea0e396dd3e8and current HEADc7d1d8ec2183b082e17c47f99e42360a600d1aad; its verified TREE isde6a73eceea53ec2e864bf1254a7de0ef7d129b6, identical to the current HEAD TREE. This synthetic CI commit is not a merge of PR #214 into master.Linux clean-source/editable: 2665 passed / 69 skipped each; isolated wheel: 2582 passed / 120 skipped. Windows clean-source/editable: 2675 passed / 59 skipped each; isolated wheel: 2585 passed / 117 skipped. Each mode also recorded 870 passing subtests. Skips are not passes, and overlapping test modes must not be added as unique coverage.
Historical Ubuntu/Windows success on original
34d02e44...is separate evidence, not reused as qualification of the updated HEAD. No manual dispatch or rerun was requested.Independent model source review — Opus 5.5 High R2
The owner accepted the completed R2 source review for integration of this exact narrow A4/A3 patch: overall PASS WITH CONDITIONS; A4 PASS WITH CONDITIONS; A3 PASS WITH CONDITIONS; no blocking code defect reported within the reviewed scope. This is a separate model source review, not a new test run, a formal GitHub reviewer identity attestation, or proof of whole-system security.
14e54a0c30403972b44afd9bb4069b4ea02c7af63721000055e45fdfabc68edc.claude-opus-5-5-high; requested effort:high.5e2b677c-d97e-4d0e-a271-8fbe7ad0b6e0; completed 2026-10-20T20:37:33.259780+00:00; CLI exit 0 / SUCCESS.248b6c52fa17241f420ca93372e318fa76d49dbb1691039d52220d5d10f0f4c5; end markerPR214_END_13154216e88edbfa9ec3reproduced in the response.The reviewer supports the saved-row binding check and attempted/confirmed publication separation in the stated trusted-host model. A host source inspection additionally found the visible demo uses the durable store and inspects status/commit_state/receipt; that limited inspection is separate from the model report and is not a new test run.
Accepted compatibility conditions and retained nonblocking observations
admit()dictionary must acceptattempt_publication_idand the narrowedpublication_idsemantics. A HOLD can retain a confirmed publication ID after failed readback; no authority follows from that ID alone.Historical status of the A3_R1/A4_R1 documents
The owner explicitly accepts
docs/PERSON_ADMISSION_PUBLICATION_RESULT_A3_R1.mdanddocs/PERSON_R21H_MEMORY_BINDING_A4_R1.mdas historical records of their individual local corrective stages. Their older parent/base SHAs, local-stage restrictions and the A4-stage statement that A3 remains red describe those earlier stages, not the current combined A4+A3 PR. Current pinned source, CI and review evidence are identified in this description. Both document files remain byte-identical to the reviewed HEAD; no evidence manifests or historical records were rewritten. The review's documentation observation is retained, not silently removed or claimed fixed in source.Authorization boundary and post-merge verification
The accepted token permits this description update, Ready transition and one ordinary merge commit of the exact HEAD into the pinned BASE after a fresh passing preflight. Any base/head/tree/scope/CI/protection drift requires STOP. No squash, rebase, force-push, new feature-branch commit, additional source edit, protection bypass, auto-merge or branch deletion is authorized. The merge result must have BASE as first parent, HEAD as second, and the exact expected TREE above; post-merge Actions must be read separately from pre-merge CI.
#209/#210/#215 and already merged PRs are outside the mutation scope. Their heads, base-branch settings and metadata must remain unchanged; #215 is not retargeted by this operation. Separate issues and remaining risks are not automatically closed. No deployment, release, installation/runtime switch, Scheduler/TPM/service change, real personal-data ingestion or trading is authorized.
Acceptance of the narrow corrective integration is not blanket closure of every A3/A4-related risk and is not production admission. Nonblocking review observations and all stated trust-boundary limitations remain recorded.
C0 HOLD;T11/T12 UNEXECUTED;NOT_PRODUCTION_ADMITTED;execution_authority=NONE;can_execute=false;can_trade=false;capital_permission=DENY.