Splitting up txs.ts into different stages based on purpose#65
Open
Splitting up txs.ts into different stages based on purpose#65
Conversation
ghost
assigned
colatkinson
requested changes
Apr 3, 2018
Member
colatkinson
left a comment
colatkinson
left a comment
There was a problem hiding this comment.
Currently does not pass Travis, and there are some syntax errors in txs.ts at a minimum. Also, can you guys merge in the latest master?
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 6 10 +4
Lines 438 438
Branches 69 69
=======================================
Hits 433 433
Misses 5 5
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure all the right functions have been moved and that the code is properly refactored intuitively.