Update index.js#47
Open
Efiloglu wants to merge 24 commits into
Open
Conversation
bitsagarob
reviewed
Jul 13, 2019
| // 1c: change the inner html of the header element to your name | ||
| function changeHeader(){ | ||
| console.log('test'); | ||
| let header = document.getElementsByTagName("h1")[0]; |
Owner
There was a problem hiding this comment.
try to indent your code consistently
bitsagarob
reviewed
Jul 13, 2019
| // 2e: to change the image: assign the imageInputValue to the image src | ||
|
|
||
| function changeImage(){ | ||
| let imageInput = document.querySelector('input'); |
bitsagarob
reviewed
Jul 13, 2019
| } | ||
|
|
||
|
|
||
| @media screen and (max-width:480px) { |
bitsagarob
reviewed
Jul 13, 2019
| } | ||
|
|
||
| img { | ||
| height: 10rem; |
bitsagarob
reviewed
Jul 13, 2019
| color: red; | ||
| margin-top: 2em; | ||
| letter-spacing: 3px; | ||
| background: linear-gradient(90deg, rgb(255, 0, 0), rgb(0, 0, 0), rgb(255, 0, 0)); |
bitsagarob
reviewed
Jul 13, 2019
| p3.innerHTML = details[titles[i]].Language; | ||
| let img = document.createElement("img"); | ||
| img.src = images[titles[i]]; | ||
|
|
Owner
There was a problem hiding this comment.
you could create an array of elements to add and then loop that array and appendChild every item
bitsagarob
approved these changes
Jul 13, 2019
Owner
bitsagarob
left a comment
bitsagarob
left a comment
There was a problem hiding this comment.
Great job! few small remarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.