Skip to content

[AI-0307] feat(endpoint): bump ipc-api pin, tripwire to allowed path - #503

Merged
Xuepoo merged 1 commit into
mainfrom
carryctx/ai-0307
Oct 16, 2026
Merged

Xuepoo merged 1 commit into
mainfrom
carryctx/ai-0307

Conversation

@Xuepoo

@Xuepoo Xuepoo commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Consume bitty-ipc#31 (merged f201911): bump bitty-ipc-api pin d0c4ecd to f201911 (lockfile moves exactly the api rev); tripwire now asserts Ready + tolerant dispositions; gate-5 stranger refusal holds.\n\nReview: APPROVE (PX-1340 ai-0307-reviewer).\nGates: just check + cargo deny check, green.\n\nPriority: P2 | Area: ipc | Labels: feat,P2 | Milestone: v0.1.0 | RFC: AIQ-38 | Task: AI-0307

Summary by CodeRabbit

  • New Features
    • Dispatch requests can now include correlator parameters and proceed to processing when they meet the schema requirements.
  • Bug Fixes
    • Missing or outdated sightings are tolerated during request handling, rather than preventing dispatch.

Bump bitty-ipc-api pin d0c4ecd to f201911 (schema allowance,
bitty-ipc#31): lockfile moves exactly the api rev line. Update
endpoint correlator tripwire to assert the allowed path: shaped,
fieldless, and stale-sighting dispatches all Ready with tolerant
dispositions; gate-5 stranger refusal holds.

Review: APPROVE (PX-1340 ai-0307-reviewer).
Gates: just check + cargo deny check, green.

Priority: P2 | Area: ipc | Labels: feat,P2 | Milestone: v0.1.0
RFC: AIQ-38 | Task: AI-0307
@Xuepoo Xuepoo added feat Feature P2 Priority: medium labels Oct 16, 2026
@Xuepoo Xuepoo added this to the v0.1.0 milestone Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2b033386-16e7-46e0-9290-5df4423d99b3
📥 Commits

Reviewing files that changed from the base of the PR and between 1b99abb and e051f9d.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 3
  • crates/bitty-ai-endpoint/Cargo.toml
  • crates/bitty-ai-endpoint/src/lib.rs
  • deny.toml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The endpoint dependency now uses bitty-ipc-api revision f201911. Comments describe gate 5 accepting the optional correlator field. Dispatch tests cover shaped and fieldless requests, result schema validity, classifications, and stale snapshot sightings.

Changes: Correlator dispatch

Layer / File(s) Summary
Dispatcher revision and schema allowance
crates/bitty-ai-endpoint/Cargo.toml, crates/bitty-ai-endpoint/src/lib.rs, deny.toml
The dependency pin and related comments identify revision f201911 and describe gate 5 accepting the optional correlator field.
Correlator dispatch tests
crates/bitty-ai-endpoint/src/lib.rs
Tests cover shaped ai.model_select and fieldless ai.mcp_snapshot requests. They check schema-valid results, current and unchecked classifications, absence of the correlator from result JSON, and successful stale-sighting dispatch with StaleTolerated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to e051f

No actionable issue remains; the change is mergeable after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the endpoint changes: the ipc-api pin update and the tripwire change to the allowed dispatch path.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Xuepoo
Xuepoo merged commit 7879757 into main Oct 16, 2026
11 checks passed
@Xuepoo
Xuepoo deleted the carryctx/ai-0307 branch October 16, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Feature P2 Priority: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant