Repository navigation
test(settings): pin composer#23 declared-key activation - #24
Merged
Merged
Conversation
composer#23 reports activation aborting on Bitty 0.0.24 with `E_SETTINGS_UNDECLARED` for `newline`. The five declarations landed in `de75a3f` (PR #20); the runtime matrix installed `c9e94c4`, a stale pre-declaration branch, so main was already past the defect while the empty-settings and explicit-value activation paths were not pinned against the declared key set. Add `tests/settings-declarations.test.ts`: - the manifest `[settings]` key set must equal exactly the keys registration reads (`M.DEFAULT_KEYS` plus `open_chord`), derived from the entry point instead of a hand-maintained list; - declared kinds and shipped defaults must match the Lua fallbacks; - activation must succeed with an empty settings file and with no settings bridge values at all, routing the shipped default chords (Enter inserts, Ctrl+Enter submits); - explicit `newline`/`submit` values must be honored; - the declared-key model must stay closed, which is the shape the host turns into `E_SETTINGS_UNDECLARED`. Task: CTX-0010 Closes #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer#23 recorded activation aborting on Bitty 0.0.24 with
E_SETTINGS_UNDECLAREDfornewline. The five declarations landed inde75a3f(PR #20); the runtime matrix installedc9e94c4, a stalepre-declaration branch, so
mainwas already past the defect, but theempty-settings and explicit-value activation paths were not pinned against the
declared key set.
This PR adds
tests/settings-declarations.test.ts.What the suite pins
[settings]key set equals exactly the keys registrationreads, derived from the entry point (
M.DEFAULT_KEYSplusopen_chord)rather than a hand-maintained list.
bridge values at all, routing the shipped default chords (Enter inserts,
Ctrl+Enter submits).
newline/submitvalues are honored.E_SETTINGS_UNDECLARED.Verification
just checklocally: all gates pass,86 pass / 0 failacross 6 files.retest installed
composeratc2e8249and activation loggedplugin 'bitty-terminal.composer' active (5 commands, 3 events).Closes
Closes #23
Priority: P1 | Area: architecture | Labels: bug, P1, area:architecture | Milestone: v0.1.0 | Task: CTX-0010