Repository navigation
fix(test): tolerate a shallow Core checkout in the parity pin - #19
Merged
Merged
Conversation
The parity pin (`HISTORY_READ_MERGE`, bitty 76fa42d6) is an ancestor of `origin/main` upstream, but the local Core checkout is shallow. A shallow clone grafts its boundary commits parentless, so `git merge-base --is-ancestor` cannot traverse past the boundary and the test failed on a healthy main. Skip only the ancestry proof when `git rev-parse --is-shallow-repository` reports true, with a notice, and keep the surface assertion that proves the history-read capability is present at fresh `origin/main`. Full checkouts still prove the pin.
Xuepoo
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority: P2 | Area: plugins | Labels: fix, P2, area:plugin | Milestone: v0.1.0 | RFC: none | Task: fleet hygiene pass
Summary
suite.
Why
The
HISTORY_READ_MERGEpin (bitty76fa42d6, PR #1673) is not stale:GitHub reports
mainas 416 commits ahead and 0 behind that commit, so it isan ancestor upstream. The local Core checkout is shallow, and a shallow clone
grafts its boundary commits parentless;
git merge-base --is-ancestorcannottraverse the boundary, so the test failed on a healthy
main.The fix skips only the ancestry proof when
git rev-parse --is-shallow-repositoryreportstrue, prints a notice, andkeeps the surface assertion that proves the history-read capability exists at
fresh
origin/main. Full checkouts still prove the pin.Verification
BITTY_WORKSPACE=<workspace> just checkpasses; the live parity suite runs(58 tests) and prints the shallow-checkout notice.