Repository navigation
Add provider-neutral code review and change-request primitives - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@foldworks/reviewwith generic anchored threads, acknowledged comment and suggestion drafts, pending reviews, reviewer status, changed-file navigation, checks, merge requirements, and change-request headers, while leaving transport, storage, identity, permissions, policy, and merging to hosts.Extends
@foldworks/diff-viewerwith text diff generation and serialization, intraline highlights, line slots and annotations, highlighting hooks, revision anchor mapping, context expansion, semantic value diffs, and diagnostic conversion; also adds checkable Tree composition and timeline activity slots and updates graph subscriptions for the current Foldkit API.Replaces the diff fixture with a persistent browser-local configuration review reference covering edit through merge and history, and includes the implementation spec, package registration, README guidance, changesets, unit tests, browser scenarios, and consumer validation.
Validation passed:
pnpm checkafter every step and on final sources, all 123 Chrome e2e tests, both expanded reference scenarios, andpnpm pack:checkfor 22 tarballs plus a clean Vite/Vitest consumer.Open workspace in Conductor