feat: FeOt redox basis, instance-aware Fe split, MagmaOcean + fractionation fixes - #6
Closed
bknight1 wants to merge 8 commits into
Closed
feat: FeOt redox basis, instance-aware Fe split, MagmaOcean + fractionation fixes#6bknight1 wants to merge 8 commits into
bknight1 wants to merge 8 commits into
Conversation
…ide conversion tests
Add a new Jupyter notebook demonstrating garnet–clinopyroxene Fe2+–Mg thermometry (S10 eclogite) and update Tutorials/Garnet/README.md with an entry linking the notebook. Fix plotting in src/phasetools/models/garnet_growth.py by using the correct radius arrays (r instead of r_r) for the size-distribution plot and class vertical lines, and remove an obsolete/duplicated summary plotting block to clean up the function.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_phase_fe_split;Fe2/Fe3key casing fix;get_phase_mg2_number; solvus (multi-instance) handling documentedfe_basis; weight-basis fractionation; extendedextract_from_grid(apfu / mg_number / instance);PhaseFunctions.fractionate_phaseMagmaOcean(renamed) with bulk preservation across fractional stages; unit-basis garnet fractionationAGENTS.md; remove legacy Copilot/agent memory filesTest plan
python3 -m unittest discover tests(78 tests pass, 1 skipped — Julia-dependent site-occupancy test)phasetools-julia-setup --check(reviewer with Julia env)