Repository navigation
Autosave and UI improvements - #106
Merged
Merged
Conversation
…t 0 (opt-in via a setting, default off)
…through Settings. Also move Preset to be the second menu item.
Collaborator
|
I hold the alternate footswitch and use the encoder for effect switching, but this change makes sense and feels normal to use so LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR includes #105 (as in, the Dual Echo effect module is included here), but doesn't depend on it – I just didn't want to worry about multiple parallel branches. Please review #105 first.
There are two changes included here, under the banner of making the pedal more intuitive to use, especially when switching between effects regularly. However, they are strictly speaking independent.
This is how I expected the pedal to behave ("why aren't my settings saved?") – I would frequently forget to save things. It will never change any preset other than Preset 0, which is the one loaded by default when starting up or switching effects.
I like this a lot better because, in my mind, "Settings" is for global settings like "true bypass" or MIDI, which are mostly "once and done", but changing effects is something you might do in normal operation. It saves a couple of clicks, and it's more intuitive to me at least that it should work this way.
As part of this change, I also moved Preset to be the second menu item, because presets belong with the current effect, and so it feels natural they come just after the first menu that contains the effect name.