Repository navigation
Fix the encoder wheel direction when browsing through effects whilst holding secondary footswitch - #108
Merged
Conversation
…ilst holding the alt footswitch
Collaborator
|
I have no explanation 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this was intentional but ... when holding down the secondary fooswitch and using the encoder wheel to change effects, the direction was the opposite to what it is in the menu system. In the menu system (and logically to me at least), clockwise = next effect, counter-clockwise = previous effect. When alt footswitch + encoder, it was the other way around.