Repository navigation
️🛠 - Run the Rust tests in CI with the desktop feature - #209
Merged
Merged
Conversation
Bump rustls, rustls-webpki and webpki-root-certs to patched versions. zip only arrives through tauri-plugin-updater, and 2.14.1 is the first release on zip 9, so upgrade the plugin. It requires Tauri 2.12, so the npm api and updater packages move with it to avoid a version mismatch in `tauri build`.
`tauri build` checks the copy hoisted to the root node_modules. After the bump to 2.12.4, yarn hoisted the 2.9.1 that older plugins resolved through ^2.8.0, which failed the version mismatch check against the tauri crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No CI workflow ran
cargo test, so a broken USB export could land unnoticed. This adds a test workflow that also runs on fork PRs. It also fixes two problems that made the flaglesscargo testfail.Changes
.github/workflows/ci.test.ymlwith two jobs onmacos-latest,rust-test-desktop(cargo test --features desktop) andrust-test(cargo test). It triggers on every push and onpull_request, withcontents: readand no secrets.src-tauri/build.rs: a featureless desktop-target build now loads onlycapabilities/default.json.desktop.jsonreferences plugins that only thedesktopfeature pulls in. Desktop-feature and mobile builds are unchanged.src-tauri/src/updater.rs:accepts_releasenow rejects every update on theOther(dev) channel. This fixesupdater::tests::dev_builds_never_update.Testing
forge verifypassed: format, typecheck, lint, andcd src-tauri && cargo test.--features desktophas not been run locally. Therust-test-desktopcheck on this PR is its first run.Notes
pushand once forpull_request. This is deliberate, because a skipped check would block merges.commands.testin.forge/config.ymltocd src-tauri && cargo test --features desktop && cargo test.services/exportto confirmrust-test-desktopfails.merge.requiredChecks.Decision
Escalated for:
protected-paths,acs. Approved by a person (daemon) on 2026-11-02.protected-paths: 1 escalate path no person approved:.github/workflows/ci.test.ymlacs: unmapped: AC1, AC2, AC3, AC4, AC5, AC6, AC7, AC8, AC9, AC10, AC11Closes #197