add function resettable#13
Open
marcelglaeser wants to merge 9 commits into
Open
Conversation
function resettable
add .rating div.star-reset
add the rating_star_reset div
add 'resettable'
Owner
|
Thanks for the pull request. It looks like you're adding an icon at the end of the stars to reset the value back to 0, which is a good catch considering that was not an included feature before. Thanks. My only comment for improvement in the readme is to include a picture of what reset looks like when enabled since it may not be immediately obvious. Thoughts? |
Author
|
You mean a picture like that? |
Owner
|
exactly like that! Just include it under the
and include a note about the resetable functionality and that it will reset the star value to 0. |
Author
|
Done. So okay? :) |
Author
|
I don't use the twig extension! |
|
Is it possible to merge this PR please ? |
Change to Font Awesome 5 Pro. It needs a Font Awesome Licence!!
Author
|
Hi, can you merge this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.