Skip to content

added half-stars and rounding to closest half #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
retosteffen wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added half-stars and rounding to closest half #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10f4f2f
added half-stars and rounding to closest half
retosteffen Nov 2, 2015
4afff19
sameas -> same as (deprecated)
retosteffen Mar 31, 2016
1c7986d
Merge branch 'fixed-sameas-to-same-as'
retosteffen Apr 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Extensions/StarRatingExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,17 @@ public function getFilters()

public function rating($number, $max = 5, $starSize = "")
{

$roundDown=floor($number);
$roundUp=ceil($number);
$fraction=(round($number*2,0,PHP_ROUND_HALF_UP)/2)-floor($number);

return $this->container->get('templating')->render(
'StarRatingBundle:Display:ratingDisplay.html.twig',
array(
'stars' => $number,
'roundDown' => $roundDown,
'roundUp'=>$roundUp,
'fraction'=>$fraction,
'max' => $max,
'starSize' => $starSize
)
Expand Down
17 changes: 17 additions & 0 deletions Resources/public/css/rating.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,23 @@
color:#e3cf7a;
}

.rating div.star-half {
font-family:FontAwesome;
font-weight:normal;
font-style:normal;
font-size: 25px;
display:inline-block;
position: relative;
}

.rating div.star-half:before {
content:"\f123";
padding-right:5px;
color:#e3cf7a;
}



.rating div.star-empty {
font-family:FontAwesome;
font-weight:normal;
Expand Down
3 changes: 2 additions & 1 deletion Resources/views/Display/ratingDisplay.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<div class="rating">
{% for i in 1..max %}
<div class="{% if i <= stars %}star-full{% else %}star-empty{% endif %} {{ starSize }}"></div>

<div class="{% if i <=roundDown %}star-full{% elseif i == roundUp and roundDown!=roundUp %} {%if fraction==1%}star-full{%elseif fraction==0.5%}star-half{%else%}star-empty{%endif%}{%else%}star-empty{% endif %} {{ starSize }}"></div>
{% endfor %}
</div>
4 changes: 2 additions & 2 deletions Resources/views/rating.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
{{- " " -}}
{%- if attrname in ['placeholder', 'title'] -%}
{{- attrname }}="{{ attrvalue|trans({}, translation_domain) }}"
{%- elseif attrvalue is sameas(true) -%}
{%- elseif attrvalue is same as(true) -%}
{{- attrname }}="{{ attrname }}"
{%- elseif attrvalue is not sameas(false) -%}
{%- elseif attrvalue is not same as(false) -%}
{{- attrname }}="{{ attrvalue }}"
{%- endif -%}
{%- endfor -%}
Expand Down