fix(keys): skip key transformation for non-plain objects like Date (#356)#364
Open
MohammadYusif wants to merge 1 commit into
Open
fix(keys): skip key transformation for non-plain objects like Date (#356)#364MohammadYusif wants to merge 1 commit into
MohammadYusif wants to merge 1 commit into
Conversation
fed01b1 to
edbb168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changeKeystreatedDate(and any non-plain object) as a plain object to recurse into, because theisObjectguard only checked!== null && typeof === "object"{}objects, breaking prototype methods like.toISOString()Date,RegExp,Map,Set, class instances) should be returned as-isChanges
packages/change-case/src/keys.ts: addedisPlainObjecthelper checking the prototype chain; addedif (!isPlainObject(object)) return objectguard after the array branchpackages/change-case/src/keys.spec.ts: added two regression tests forDateproperty and mixedDate+ string property objectsFixes #356