fix(title-case): don't capitalize inside HTML character references#366
Open
naveentehrpariya wants to merge 1 commit into
Open
fix(title-case): don't capitalize inside HTML character references#366naveentehrpariya wants to merge 1 commit into
naveentehrpariya wants to merge 1 commit into
Conversation
`titleCase("this & that")` produced `This &Amp; That`, breaking the
entity. Title case treated `&` as a normal word and uppercased the
first letter after `&`.
Leave whole-token HTML character references (named like `&` and
numeric like `&blakeembrey#38;` / `😀`) untouched. The trailing `;` is not a
sentence terminator, so surrounding words keep their casing.
Fixes blakeembrey#348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #348.
Problem
titleCasetreats an HTML character reference such as&as an ordinary word and capitalizes the first letter after&:The mangled entity (
&Amp;) is no longer valid and breaks HTML validation, with no usable workaround (thesmallWordsoption expects an alphanumeric word, not&).Fix
Leave whole-token HTML character references untouched — both named (
&,<, …) and numeric (&,😀). This mirrors the existing special-casing for URLs/emails/hashtags. The trailing;is not a sentence terminator, so the surrounding words keep their normal title-case behaviour.Tests
Added cases for named, decimal and hex entities, plus a bare-
&guard. The named-entity cases fail without this change; the full title-case suite (107 tests) passes with it.