Skip to content

fix: update client identifier to Blast and set correct version #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayaanoncrypto wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −9
Open

fix: update client identifier to Blast and set correct version #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion blast-geth/cmd/geth/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func defaultNodeConfig() node.Config {
cfg.Version = params.VersionWithCommit(git.Commit, git.Date)
cfg.HTTPModules = append(cfg.HTTPModules, "eth")
cfg.WSModules = append(cfg.WSModules, "eth")
cfg.IPCPath = "geth.ipc"
cfg.IPCPath = "blast.ipc"
return cfg
}

Expand Down
2 changes: 1 addition & 1 deletion blast-geth/cmd/geth/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import (
)

const (
clientIdentifier = "geth" // Client identifier to advertise over the network
clientIdentifier = "blast" // Client identifier to advertise over the network
)

var (
Expand Down
2 changes: 2 additions & 0 deletions blast-geth/node/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,8 @@ func (c *Config) NodeName() string {
// Backwards compatibility: previous versions used title-cased "Geth", keep that.
if name == "geth" || name == "geth-testnet" {
name = "Geth"
} else if name == "blast" {
name = "Blast"
}
if c.UserIdent != "" {
name += "/" + c.UserIdent
Expand Down
7 changes: 4 additions & 3 deletions blast-geth/node/node_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
"github.com/ethereum/go-ethereum/p2p"
"github.com/ethereum/go-ethereum/rpc"

pble "github.com/cockroachdb/pebble"
"github.com/stretchr/testify/assert"
)

Expand Down Expand Up @@ -152,7 +153,7 @@ func TestNodeCloseClosesDB(t *testing.T) {
stack, _ := New(testNodeConfig())
defer stack.Close()

db, err := stack.OpenDatabase("mydb", 0, 0, "", false)
db, err := stack.OpenDatabase("mydb", 0, 0, "", false, pble.FormatMostCompatible)
if err != nil {
t.Fatal("can't open DB:", err)
}
Expand All @@ -175,7 +176,7 @@ func TestNodeOpenDatabaseFromLifecycleStart(t *testing.T) {
var err error
stack.RegisterLifecycle(&InstrumentedService{
startHook: func() {
db, err = stack.OpenDatabase("mydb", 0, 0, "", false)
db, err = stack.OpenDatabase("mydb", 0, 0, "", false, pble.FormatMostCompatible)
if err != nil {
t.Fatal("can't open DB:", err)
}
Expand All @@ -196,7 +197,7 @@ func TestNodeOpenDatabaseFromLifecycleStop(t *testing.T) {

stack.RegisterLifecycle(&InstrumentedService{
stopHook: func() {
db, err := stack.OpenDatabase("mydb", 0, 0, "", false)
db, err := stack.OpenDatabase("mydb", 0, 0, "", false, pble.FormatMostCompatible)
if err != nil {
t.Fatal("can't open DB:", err)
}
Expand Down
8 changes: 4 additions & 4 deletions blast-geth/params/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ const (

// OPVersion is the version of op-geth
var (
OPVersionMajor = 0 // Major version component of the current release
OPVersionMinor = 1 // Minor version component of the current release
OPVersionPatch = 0 // Patch version component of the current release
OPVersionMeta = "unstable" // Version metadata to append to the version string
OPVersionMajor = 1 // Major version component of the current release
OPVersionMinor = 8 // Minor version component of the current release
OPVersionPatch = 0 // Patch version component of the current release
OPVersionMeta = "stable" // Version metadata to append to the version string
)

// This is set at build-time by the linker when the build is done by build/ci.go.
Expand Down