Fix LiveKit reasoning effort default for gpt-5.4 models#144
Merged
mstolarzblaxelai merged 1 commit intoMay 14, 2026
Conversation
Contributor
There was a problem hiding this comment.
LGTM
Fix is correct and well-scoped. No security, correctness, or data-loss issues.
Tag @mendral-app with feedback or questions. View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ENG-2508.
What changed:
reasoning_efforttononefor Blaxel-resolved OpenAI gpt-5.4 models.reasoning_effortexactly.Why:
gpt-5.4-minitominimal.minimalfor this model. Supported values includenone,low,medium,high, andxhigh.Verified:
uv run --locked --python 3.12 --extra livekit --group test pytest tests/integration/livekit/test_model.py::test_gpt54_openai_models_default_reasoning_effort_to_none tests/integration/livekit/test_model.py::test_livekit_reasoning_effort_override_is_preserved tests/integration/livekit/test_model.py::test_livekit_non_openai_provider_does_not_default_reasoning_effort -qBL_WORKSPACE=main uv run --locked --python 3.12 --extra livekit --group test pytest tests/integration/livekit/test_model.py::TestBlModel::test_can_call_model -qBL_WORKSPACE=main uv run --locked --python 3.12 --extra livekit --group test pytest tests/integration/livekit -quv run ruff check .make testgit diff --checkNote
Adds a helper that defaults
reasoning_effortto"none"for gpt-5.4 family models on the OpenAI provider in the LiveKit integration, preventing Blaxel from rejecting the LiveKit-default value of"minimal". Three focused unit tests cover the happy path, caller override, and non-OpenAI provider passthrough.Written by Mendral for commit dd8df73.