[codex] add paginated controlplane list responses#145
Draft
cploujoux wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
LGTM
The legacy-compat fix in 57f03f7 is correct: Unset.__bool__ returns False, so list(items or []) in split_list_response safely handles a dict without a "data" key. The from_dict early-return of None for empty legacy arrays is consistent with prior empty-response behavior. No issues found.
Tag @mendral-app with feedback or questions. View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blaxel-Versionto2026-04-28..data,.has_more,.next_cursor,.next_page(), and.auto_paging_iter()in README and method docstrings.Tests
uv run ruff checkuv run pytest tests/core/test_settings_api_version.py tests/core/test_controlplane_pagination.py -vuv run pytest tests/ -v --ignore=tests/integration/ --ignore=tests/sandbox/integration/Notes
BL_API_KEYandBL_WORKSPACEwere not exported in this shell.Note
Adds cursor-paginated list responses to the controlplane client layer. The initial commit regenerates all list API functions to accept
cursor/limit/sort/qparameters, wraps responses in*Listmodels, and introducesPaginatedList/AsyncPaginatedList(both extendinglist[T]) with.data,.has_more,.next_cursor,.next_page(), andauto_paging_iter(). The follow-up commit addssplit_list_response()to transparently normalize legacy bare-array API responses into the new{data, meta}shape, updating all nine*List.from_dict()methods to acceptdict | list.Written by Mendral for commit 57f03f7.