Skip to content

Fix sync multipart upload error handling#149

Merged
mstolarzblaxelai merged 1 commit into
mainfrom
codex/python-sync-multipart-errors
May 26, 2026
Merged

Fix sync multipart upload error handling#149
mstolarzblaxelai merged 1 commit into
mainfrom
codex/python-sync-multipart-errors

Conversation

@mstolarzblaxelai
Copy link
Copy Markdown
Contributor

@mstolarzblaxelai mstolarzblaxelai commented May 26, 2026

  • Propagates sync multipart part-upload failures from worker threads.
  • Aborts failed multipart uploads instead of completing with missing parts.
  • Adds local regression coverage.

Note

Adds exception propagation from worker threads in the sync multipart upload path. Previously, part failures were silently swallowed; now exceptions are collected under a lock and re-raised after all threads join, which triggers the existing _abort_multipart_upload cleanup in the outer except block.

Written by Mendral for commit edf972e.

Copy link
Copy Markdown
Contributor

@mendral-app mendral-app Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The fix is correct. Thread safety is handled properly via results_lock for both results and exceptions writes. The raise exceptions[0] correctly propagates through the outer except block, ensuring _abort_multipart_upload is always called on failure. No issues found.

Tag @mendral-app with feedback or questions. View session

@mstolarzblaxelai mstolarzblaxelai marked this pull request as ready for review May 26, 2026 23:42
@mstolarzblaxelai mstolarzblaxelai merged commit 13b8456 into main May 26, 2026
19 checks passed
@mstolarzblaxelai mstolarzblaxelai deleted the codex/python-sync-multipart-errors branch May 26, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant