Skip to content

[codex] Update sdk-go pagination handling#302

Draft
cploujoux wants to merge 1 commit into
mainfrom
codex/sdk-go-0-21-list-all-pagination
Draft

[codex] Update sdk-go pagination handling#302
cploujoux wants to merge 1 commit into
mainfrom
codex/sdk-go-0-21-list-all-pagination

Conversation

@cploujoux
Copy link
Copy Markdown
Contributor

@cploujoux cploujoux commented May 19, 2026

Summary

  • Update github.com/blaxel-ai/sdk-go to v0.21.0.
  • Keep CLI list behavior unchanged by fetching all cursor-paginated pages internally.
  • Update completions, nested job execution listing, and tests for the new {data, meta} response shape.

Validation

  • go test ./...
  • make build-dev
  • ~/.local/bin/bl version

Note

Updates sdk-go from v0.18.0 to v0.21.0, adapting the CLI to the new cursor-paginated {data, meta} response shape. Introduces a generic listAllPages helper that transparently fetches all pages, with cursor loop detection, and replaces all direct .List() calls across completions, commands, and operations.

Written by Mendral for commit 4d3063f.

@cploujoux cploujoux requested a deployment to integration-tests May 19, 2026 17:49 — with GitHub Actions Waiting
Copy link
Copy Markdown
Contributor

@mendral-app mendral-app Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The pagination logic is correct: hasMore && nextCursor != "" guards loop continuation, the cursor deduplication map catches infinite loops, and context cancellation propagates properly through each page fetch. No correctness, security, or data loss issues found.

Tag @mendral-app with feedback or questions. View session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant