fix(cli): increase default deploy/push timeout from 15m to 1h#312
Merged
Conversation
…d idle timeouts The 15-minute timeout on bl deploy and bl push was an absolute timer that fired regardless of whether the build was actively making progress. This caused false timeout failures for long-running but healthy builds. Changes: - deploy.go: Replace time.After with activity-tracking in both deployResourceInteractive and deployAdditionalResource. The idle timer resets on status changes and incoming build log entries. - push.go: Same activity-based idle timeout for watchBuildLogsNonInteractive. - Update --timeout flag descriptions to clarify idle behavior. - Error messages now say 'no progress detected for <duration>' instead of 'deployment timed out after <duration>'. Fixes ENG-2691 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![mendral-app[bot]](https://avatars.githubusercontent.com/in/1975249?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Joffref
approved these changes
May 28, 2026
The 15-minute default timeout on bl deploy and bl push was too short for long-running builds. Increase to 1 hour. Fixes ENG-2691 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
changed the title
Contributor
There was a problem hiding this comment.
LGTM
The follow-up commit is a straightforward default value bump from 15m to 1h across DefaultBuildTimeout, the --timeout flag descriptions, and the inline comment — no logic changes. No new issues introduced.
Tag @mendral-app with feedback or questions. View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increases the default timeout for
bl deployandbl pushfrom 15 minutes to 1 hour. The 15-minute default was too short for long-running builds, causing false timeout failures even when deployments would eventually succeed.Changes:
cli/monitor/logs.go:DefaultBuildTimeoutconstant changed from15 * time.Minuteto1 * time.Hourcli/deploy.goandcli/push.go:--timeoutflag help text updated to reflect new defaultFixes ENG-2691
Review & Testing Checklist for Human
Notes
--timeoutflag still works as before for users who want a custom value.blaxel/retain their own 10m default (unchanged)Link to Devin session: https://app.devin.ai/sessions/cc633686568a4dfb9e8ed7010d09e5f2
Requested by: @Joffref
Note
Converts absolute 15-minute timeouts in
bl deployandbl pushto activity-based idle timeouts, then increases the default from 15m to 1h. The idle timer resets on status transitions and incoming build log entries.Written by Mendral for commit 119a6f1.