question about ForceSavingPosition / crashing sending players back to their bed/spawn on dedicated servers?

[dreamwraith]

hey! ran into something recently on our dedicated server and was digging through the code to see what happened, but wanted to ask here in case i'm misunderstanding how this works.

sometimes when a player's game crashes, they log back in and find themselves teleported all the way back to their bed or world spawn instead of near where they were when they crashed (even though their inventory and skills saved fine from the auto-save).

i was looking at ClientSide.cs and saw the ForceSavingPosition patch on Game.SavePlayerProfile:

if (ZNet.m_world == null || __instance.m_playerProfile.HaveLogoutPoint())
{
    originalValue = true;
    return;
}

i might be mistaken, but isn't ZNet.m_world always null on clients when connected to a dedicated server?

if that's the case, wouldn't this check always return early on clients during periodic auto-saves, meaning setLogoutPoint = true never actually happens? and then if the client crashes (so normal clean logout never runs), the server never gets their field position and valheim just defaults to sending them back to their bed?

would changing ZNet.m_world == null to something like Player.m_localPlayer == null make it so auto-saves actually save their position in case of a crash? or was ZNet.m_world == null checking for something specific here that i'm missing?

thanks a bunch for the mod!

[blaxxun-boop]

The inventory is always up to date, yes. It gets synced on every change to it.

The position isn't, because when it worked like that, we had plenty of people complain that they respawned in the middle of the ocean, if their game crashed while they are on a ship.

[dreamwraith]

I think the actual issue I thought I found was unrelated - it was the old vanilla bug with regards to clients with a ghost session who don't know they are ghosted until the world stops loading new things. Player lost 3 hrs of playtime sitting in their base working not knowing they lost connection to the server.

I'm talking to someone else about a standalone fix for that vanilla bug involving putting a periodic check of the server heartbeat to trigger the client to realize its disconnected, but it would make sense to put that in something like this mod as well.