Repository navigation
feat: add GBP currency support - #80
Merged
Merged
Conversation
The live API accepts GBP on the payout FX (to) and payin FX (from/to) endpoints. Mirror the EUR support from #77: add GBP to the shared Currency union, the FX input types, and the payin response currency.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live API accepts GBP on both FX endpoints, but the SDK doesn't type it yet. This mirrors #77 (EUR) for GBP:
GBPto the sharedCurrencyunionGBPinquotes.getFxRate(to) andpayins.quotes.getFxRate(from)GBPtoPayin.currencyminorchangeset, matching the EUR onePayout
currencyfields useCurrencydirectly, so they pick up GBP without changes.Notes for review
Payin.currencyis an assumption. The live request schemas confirm GBP on the FX endpoints (POST /quotes/fxto,POST /payin-quotes/fxfrom/to), but I couldn't check the payin response schema. WideningPayin.currencyfollows the EUR precedent and the payin FX enum..api-syncchange. The committedspec-snapshot.jsonpredates GBP, so there's no unmodeled entry to drop. Api-sync may flag GBP once the snapshot is refreshed.faster_paymentsbank account rail, which isn't inRailor the bank-account types yet. That should be a separate PR.Testing
bun run check-typesbun run lint:checkbun run test(189 passed)bun run contract-checkbun run sync:check