Skip to content

fix: Overriden custom cookies with pages router#4427

Merged
siddhsuresh merged 4 commits intomainfrom
siddharth/fix-set-cookie-issue-in-pages-router
Mar 3, 2025
Merged

fix: Overriden custom cookies with pages router#4427
siddhsuresh merged 4 commits intomainfrom
siddharth/fix-set-cookie-issue-in-pages-router

Conversation

@siddhsuresh
Copy link
Copy Markdown
Member

@siddhsuresh siddhsuresh commented Mar 1, 2025

Closes: ?

What are the changes and their implications?

will backport to v2

Missing change from #4424

Bug Checklist

  • Changeset added (run pnpm changeset in the root directory)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 1, 2025

🦋 Changeset detected

Latest commit: 9845672

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@blitzjs/auth Patch
@blitzjs/rpc Patch
@blitzjs/next Patch
@blitzjs/codemod Patch
@blitzjs/config Patch
@blitzjs/generator Patch
blitz Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddhsuresh siddhsuresh marked this pull request as ready for review March 1, 2025 05:20
@siddhsuresh siddhsuresh requested a review from flybayer as a code owner March 1, 2025 05:20
@siddhsuresh siddhsuresh marked this pull request as draft March 1, 2025 16:28
@siddhsuresh siddhsuresh removed the request for review from flybayer March 1, 2025 16:28
@siddhsuresh siddhsuresh marked this pull request as ready for review March 3, 2025 06:34
@siddhsuresh siddhsuresh merged commit 0ef8de0 into main Mar 3, 2025
30 checks passed
@siddhsuresh siddhsuresh deleted the siddharth/fix-set-cookie-issue-in-pages-router branch March 3, 2025 08:25
siddhsuresh added a commit that referenced this pull request Mar 3, 2025
* fix overriden cookies in pages router

* Create stale-keys-guess.md

* fix and add test

* fix missing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants