[Patch] Adjust crafted item quality mapping and exceptions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Orange color mapping from Normal to Crafted and add an exception: when an item resolves to Crafted but its description includes "Rune", "Essence", or "Token", treat it as Normal.
✅ Deploy Preview for limedrop ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for determining item quality in the
buildV1ItemInfofunction to better handle items with the color orange and to correctly classify certain special items. The most important changes are:Quality Mapping Adjustments:
sdk.colors.Orangefromsdk.items.quality.Normaltosdk.items.quality.Craftedin thecodeToQualityobject.Special Case Handling:
Normalquality if their description includes "Rune", "Essence", or "Token", even if their color would otherwise indicateCraftedquality.