Set websocket max_size to 2**24.#5
Open
doubleukay wants to merge 1 commit into
Open
Conversation
In bxcommon commit a3f68b623afc20cf5bbe773bc09eae32fafe5261, max_size was set to 2**24. Without it, the websocket connection may break when streaming blocks containing many transactions. As WsProvider and CloudWssProvider override AbstractWsProvider's connect_websocket() and aren't inheriting the max_size setting, set it manually for them.
Author
|
This fixes the problem "Websocket disconnected due to transport layer exception: over size limit (1299123 > 1048576 bytes)" |
sasha00123
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
I totally agree. Wish it could be merged. @shanevc @Uri-Margalit-bloXroute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bxcommon commit a3f68b623afc20cf5bbe773bc09eae32fafe5261, max_size
was set to 2**24. Without it, the websocket connection may break when
streaming blocks containing many transactions.
As WsProvider and CloudWssProvider override AbstractWsProvider's
connect_websocket() and aren't inheriting the max_size setting, set it
manually for them.