Skip to content

fix(release): forward unix provenance arguments #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalvinnchau merged 1 commit into from
Aug 13, 2026
Merged

fix(release): forward unix provenance arguments #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ release-reconcile-assets repository tag version output_file:
[unix]
[positional-arguments]
release-write-provenance source_sha version platform output_dir *ASSETS:
bash -euo pipefail -c 'scripts/release/write-provenance.sh "$@"' _ "$1" "$2" "$3" "$4" "${@:5}"
bash -euo pipefail -c 'scripts/release/write-provenance.sh "$@"' _ "$@"

# On Windows, run the shared Bash script as one generated recipe so argv remains
# positional and is not interpolated into shell source.
Expand Down
3 changes: 1 addition & 2 deletions scripts/release/tests/release-scripts.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,8 +777,7 @@ describe("desktop release workflow platform gate", () => {
2,
);
expect(provenanceRecipes).toContain(
'bash -euo pipefail -c \'scripts/release/write-provenance.sh "$@"\' _ "$1" "$2" "$3" "$4" "$' +
'{@:5}"',
'bash -euo pipefail -c \'scripts/release/write-provenance.sh "$@"\' _ "$@"',
);
expect(provenanceRecipes).toContain(
'scripts/release/write-provenance.sh "$1" "$2" "$3" "$4" "$' + '{@:5}"',
Expand Down