graduate agent share cards

[cynfria]

Category: improvement
User Impact: Agent share cards are now consistently available from the agent gallery and detail page without an experimental setting.
Problem: Agent share cards are ready for general use, but the Experiments tab still presents them as optional and can hide sharing behind a local toggle. Solution: Remove the experiment registration and runtime gates while retaining the established share-card flow and its Export fallback for reusable components.

File changes

src/features/agents/ui/AgentDetailPage.tsx
Removes the experiment lookup so the detail page displays Share whenever its share handler is available.

src/features/agents/ui/AgentsView.tsx
Always wires share-card actions into the gallery and detail surfaces and keeps the share dialog available without an experiment gate.

src/features/agents/ui/PersonaCard.tsx
Removes the experiment dependency so gallery cards use their supplied share handler directly.

src/features/agents/ui/tests/AgentsView.entry.test.tsx
Updates the graduated behavior contract and adds gallery-path coverage proving Share replaces Export and opens the dialog.

src/features/agents/ui/tests/PersonaCard.test.tsx
Updates component tests to cover handler-driven Share and the Export fallback without experiment preferences.

src/features/experiments/tests/ExperimentsSettings.test.tsx
Removes the share-card experiment from the supported experiment registry expectation.

src/features/experiments/experimentDefinitions.ts
Removes the agent share-card experiment ID and registry entry.

src/shared/i18n/locales/en/settings.json
Removes obsolete English copy for the experiment setting.

src/shared/i18n/locales/es/settings.json
Removes obsolete Spanish copy for the experiment setting.

Verification

• pnpm vitest run src/features/experiments/__tests__/ExperimentsSettings.test.tsx src/features/agents/ui/__tests__/PersonaCard.test.tsx src/features/agents/ui/__tests__/AgentsView.entry.test.tsx
• just check

[morgmart]

🤖 Automated code review

APPROVE — no publishable findings in the exact three-dot comparison. The full static review covered all nine changed files and both graduated Share entry points (gallery card and agent detail), the dialog lifecycle and Export fallback, experiment-registry cleanup, English/Spanish localization cleanup, accessibility semantics, navigation and consent behavior, async/error/never-completes/race behavior, test honesty, and design-system/project laws. No overlapping or unsupported concerns survived the final self-check. Supplied GitHub evidence was inspected: Semgrep OSS, zizmor, Tauri Rust checks on Linux/macOS/Windows, clean-room install, and DCO had succeeded; Frontend checks and unit tests were still in progress at capture time. CI state does not change the review recommendation, and required checks still govern merge readiness. No local code, tests, builds, package managers, binaries, hooks, or project scripts were run.

Deterministic publication result: 0 blocking and 0 non-blocking finding(s) publishable; 0 duplicate(s) suppressed.

Pending checks: 1 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.