Bound the block target to one week of blocks - #14
Merged
Conversation
Simulation cost grows with the block target: getExpectedBlocksMined evaluates a Poisson tail of 4 * target entries and then simulates that many blocks, so a target of 1_000_000 spends roughly two minutes of CPU. Neither the numOfBlocks argument nor the blockTargets constructor list had an upper bound, and bitcoin-augur-server passes an HTTP query parameter straight into numOfBlocks, so one unauthenticated request can saturate a core. Reject targets above MAX_BLOCK_TARGET, one week of blocks.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
sanket1729
marked this pull request as ready for review
August 5, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulation cost grows with the block target, and neither
numOfBlocksnor theblockTargetsconstructor list had an upper bound — a target of 1,000,000 spends about two minutes of CPU in a single call.bitcoin-augur-serverpasses an HTTP query parameter straight intonumOfBlocks, so one unauthenticated request can saturate a core.Rejects targets above
MAX_BLOCK_TARGET(1008).