Skip to content

fix(dialog): stop dialogs from clearing text selection on mouseup #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt2e merged 1 commit into from
Jul 15, 2026
Merged

fix(dialog): stop dialogs from clearing text selection on mouseup #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/staged/src/lib/components/ui/alert-dialog/alert-dialog-content.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@

<AlertDialogPortal {...portalProps}>
<AlertDialogOverlay />
<!--
preventOverflowTextSelection is off for the same reason as dialog-content:
WKWebView collapses the selection when bits-ui restores user-select styles
on pointerup, leaving dialog text unselectable.
-->
<AlertDialogPrimitive.Content
bind:ref
data-slot="alert-dialog-content"
Expand All @@ -27,6 +32,7 @@
'data-open:animate-in data-closed:animate-out data-closed:fade-out-0 data-open:fade-in-0 data-closed:zoom-out-95 data-open:zoom-in-95 bg-[var(--bg-alert-dialog)] text-[var(--text-primary)] ring-foreground/10 gap-6 rounded-xl p-6 ring-1 duration-100 data-[size=default]:max-w-xs data-[size=sm]:max-w-xs data-[size=default]:sm:max-w-lg group/alert-dialog-content fixed top-1/2 left-1/2 z-(--z-index-overlay) grid w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 outline-none',
className
)}
preventOverflowTextSelection={false}
{...restProps}
/>
</AlertDialogPortal>
8 changes: 8 additions & 0 deletions apps/staged/src/lib/components/ui/dialog/dialog-content.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@

<DialogPortal {...portalProps}>
<Dialog.Overlay />
<!--
preventOverflowTextSelection is off: bits-ui's selection lock rewrites
user-select on <body> and the content on pointerup, and WKWebView collapses
the just-dragged selection when that style changes — making dialog text
unselectable in the Tauri app. The overlay already covers the page behind,
so selection overflow has nothing visible to leak into.
-->
<DialogPrimitive.Content
bind:ref
data-slot="dialog-content"
Expand All @@ -104,6 +111,7 @@
style={contentStyle}
onOpenAutoFocus={(e) => e.preventDefault()}
onpointerdown={handlePointerDown}
preventOverflowTextSelection={false}
{...restProps}
>
{@render children?.()}
Expand Down