Skip to content

fix(desktop): edit the selected agent instance#2720

Open
oshtz wants to merge 1 commit into
block:mainfrom
oshtz:agent/edit-selected-agent-instance
Open

fix(desktop): edit the selected agent instance#2720
oshtz wants to merge 1 commit into
block:mainfrom
oshtz:agent/edit-selected-agent-instance

Conversation

@oshtz

@oshtz oshtz commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • route Edit on an agent profile to the selected managed-agent instance instead of the shared persona
  • show each instance's relay URL so same-persona deployments can be distinguished
  • add regression coverage proving an environment-variable update targets only the selected pubkey

Fixes #2717

Root cause

UserProfilePanel.handleEditAgent preferred resolvedPersona whenever one existed. Because managed agents are persona-backed, Edit always opened the persona-definition dialog and never reached the instance editor.

Persona definitions remain editable through the existing actions on the Agents card.

Validation

  • pnpm typecheck
  • pnpm build:e2e
  • focused integration E2E for two same-persona instances on different relays — 1 passed
  • focused smoke E2E for persona-linked profile editing — 1 passed

Signed-off-by: oshtz <omershatzberg@gmail.com>
@oshtz
oshtz force-pushed the agent/edit-selected-agent-instance branch from 4c10ef9 to 7913b33 Compare July 24, 2026 15:12
@oshtz
oshtz marked this pull request as ready for review July 24, 2026 15:13
@oshtz
oshtz requested a review from a team as a code owner July 24, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Desktop: agent settings edits always target one community's instance - per-community agent config (env vars) unreachable from the UI

1 participant